make cppcheck happy

closes #479

tests/src/mocks/openvr_mock.hpp

@@ -269,7 +269,7 @@ class OPENVR_MOCK_EXPORT OpenVRMock {
   }
 
   OpenVRMock& operator=(const OpenVRMock&) = delete;
-  OpenVRMock& operator=(OpenVRMock&&) = default;
+  OpenVRMock& operator=(OpenVRMock&&) = delete;
 
   OpenVRMockInternal& Get() { return *mock_; }
   vr::IVRSystemMock& GetSystem() const { return *ivr_system_mock_; }

tests/src/mocks/sdl_mock.hpp

@@ -66,7 +66,7 @@ class SDL_MOCK_EXPORT SdlMock {
   ~SdlMock() { delete mock_; }
 
   SdlMock& operator=(const SdlMock&) = delete;
-  SdlMock& operator=(SdlMock&&) = default;
+  SdlMock& operator=(SdlMock&&) = delete;
 
   SdlMockInternal& Get() { return *mock_; }
 

tests/src/test_vr_controller.cpp

@@ -44,7 +44,7 @@ auto first_call = std::make_shared<bool>(true);
 
 void CheckForButtonEvent(uint32_t openVR_event_type,
                          phx::VRController::ButtonEvent vr_cont_event,
-                         uint32_t button_id, std::string side,
+                         uint32_t button_id, const std::string& side,
                          bool expect_to_fire,
                          phx::VRController* vr_controller) {
   WHEN("a " + side +