Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Virtual Acoustics Plugin
Manage
Activity
Members
Labels
Plan
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
LuFG VR VIS
VR-Group
Unreal-Development
Plugins
Virtual Acoustics Plugin
Commits
996df9bf
Commit
996df9bf
authored
Apr 14, 2021
by
Philipp Schäfer
Browse files
Options
Downloads
Patches
Plain Diff
VASourceComponent: Now cannot set signal source to none
(only when reverting to default which is none unfortunately)
parent
14ab01e8
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
Source/VAPlugin/Private/VASourceComponent.cpp
+3
-15
3 additions, 15 deletions
Source/VAPlugin/Private/VASourceComponent.cpp
Source/VAPlugin/Public/VASourceComponent.h
+1
-2
1 addition, 2 deletions
Source/VAPlugin/Public/VASourceComponent.h
with
4 additions
and
17 deletions
Source/VAPlugin/Private/VASourceComponent.cpp
+
3
−
15
View file @
996df9bf
...
...
@@ -21,6 +21,9 @@ UVASourceComponent::UVASourceComponent()
{
PrimaryComponentTick
.
bCanEverTick
=
true
;
//Default objects for subcomponents does not work
//SignalSource = CreateDefaultSubobject<UVAAudiofileSignalSource>(TEXT("SignalSource"), false);
// If the receiver Actor is initialized but this sound Component not, this Component is spawned at runtime and has to be initialized
// Otherwise it will be later on initialized from the Receiver Actor
TArray
<
AActor
*>
ReceiverActors
;
...
...
@@ -637,21 +640,6 @@ FString UVASourceComponent::GetBoneName() const
#if WITH_EDITOR
void
UVASourceComponent
::
PreEditChange
(
FProperty
*
PropertyWhatWillChange
)
{
Super
::
PreEditChange
(
PropertyWhatWillChange
);
// TODO:
// This is true if user directly changes the signal source component to "None"
// However, it is also true if user changes a sub-property of SignalSource
if
(
PropertyWhatWillChange
->
GetFName
()
==
GET_MEMBER_NAME_CHECKED
(
UVASourceComponent
,
SignalSource
))
{
UnbindSignalSourceEvents
();
//Unbind works for now, since we bind in BeginPlay() again.
//SignalSourceType = nullptr;
}
}
void
UVASourceComponent
::
PostEditChangeProperty
(
FPropertyChangedEvent
&
PropertyChangedEvent
)
{
if
(
PropertyChangedEvent
.
GetPropertyName
()
==
GET_MEMBER_NAME_CHECKED
(
UVASourceComponent
,
SignalSourceType
))
...
...
This diff is collapsed.
Click to expand it.
Source/VAPlugin/Public/VASourceComponent.h
+
1
−
2
View file @
996df9bf
...
...
@@ -42,7 +42,7 @@ protected:
TSubclassOf
<
UVAAbstractSignalSource
>
SignalSourceType
=
UVAAudiofileSignalSource
::
StaticClass
();
// Select the type of the signal source
UPROPERTY
(
EditAnywhere
,
Instanced
,
meta
=
(
DisplayName
=
"Signal Source"
,
Category
=
"Signal Source"
,
AllowAbstract
=
"false"
))
UPROPERTY
(
EditAnywhere
,
Instanced
,
NoClear
,
meta
=
(
DisplayName
=
"Signal Source"
,
Category
=
"Signal Source"
,
AllowAbstract
=
"false"
))
UVAAbstractSignalSource
*
SignalSource
=
nullptr
;
...
...
@@ -241,7 +241,6 @@ private:
protected:
#if WITH_EDITOR
virtual
void
PreEditChange
(
FProperty
*
PropertyWhatWillChange
)
override
;
virtual
void
PostEditChangeProperty
(
FPropertyChangedEvent
&
PropertyChangedEvent
)
override
;
// Function to improve settings displayed in Editor, can only be used in editor mode
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment