Skip to content
Snippets Groups Projects

fix double Deletion

Merged Jan Delember requested to merge fix/double-deletion into develop

avoid attempted double deletion, if two uUniLog streams use the same file stream

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @mbellgardt

    By Jonathan Ehret on 2021-11-24T16:35:10 (imported from GitLab)

  • Jan Delember added 1 commit

    added 1 commit

    • 8d539baa - Change File_Handle raw pointer to unique pointer to make ownership explicit

    Compare with previous version

    By Martin Bellgardt on 2021-12-09T12:46:00 (imported from GitLab)

  • Author Contributor

    I did not like your solution, so I changed the raw pointer to be a unique pointer, which should have the same effect. The issue should generally not happen, though. Is it possible that your application closes a LogStream without opening it first?

    By Martin Bellgardt on 2021-12-09T12:49:56 (imported from GitLab)

  • Author Contributor

    I'm totally fine with that, so far the error did not happen with that, but it was a rather undeterministic error anyways.

    By Jonathan Ehret on 2021-12-09T13:01:35 (imported from GitLab)

  • Jan Delember approved this merge request

    approved this merge request

    By Martin Bellgardt on 2021-12-09T14:22:09 (imported from GitLab)

  • Jan Delember approved this merge request

    approved this merge request

    By Jonathan Ehret on 2022-01-10T12:22:46 (imported from GitLab)

  • Jan Delember mentioned in commit d7257923

    mentioned in commit d7257923

    By Jonathan Ehret on 2022-01-10T12:22:49 (imported from GitLab)

Please register or sign in to reply
Loading