Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
L
Line Rendering Plugin
Manage
Activity
Members
Plan
Wiki
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Package registry
Model registry
Operate
Terraform modules
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
LuFG VR VIS
VR-Group
Unreal-Development
Plugins
Line Rendering Plugin
Commits
dd9fc9f5
Commit
dd9fc9f5
authored
Aug 18, 2020
by
David Gilbert
Browse files
Options
Downloads
Patches
Plain Diff
Fixed a crash that happened when trying to clear an EditorLine's points array.
parent
01b0f520
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
Source/InstancedMeshLineRendering/Private/GPUInstancedLineComponent.cpp
+3
-3
3 additions, 3 deletions
...edMeshLineRendering/Private/GPUInstancedLineComponent.cpp
with
3 additions
and
3 deletions
Source/InstancedMeshLineRendering/Private/GPUInstancedLineComponent.cpp
+
3
−
3
View file @
dd9fc9f5
...
@@ -329,7 +329,7 @@ void UGPUInstancedLineComponent::PostEditChangeChainProperty(FPropertyChangedCha
...
@@ -329,7 +329,7 @@ void UGPUInstancedLineComponent::PostEditChangeChainProperty(FPropertyChangedCha
const
int32
NumberOfPointsToRemove
=
FMath
::
Max
(
NumberOfPoints
-
2
,
0
);
const
int32
NumberOfPointsToRemove
=
FMath
::
Max
(
NumberOfPoints
-
2
,
0
);
for
(
int32
PointToRemove
=
0
;
PointToRemove
<
NumberOfPointsToRemove
;
PointToRemove
++
)
for
(
int32
PointToRemove
=
0
;
PointToRemove
<
NumberOfPointsToRemove
;
PointToRemove
++
)
{
{
RemovePoint
(
EditorLines
[
EditorLineIndex
].
RespectiveLineId
,
2
+
PointToRemove
);
RemovePoint
(
EditorLines
[
EditorLineIndex
].
RespectiveLineId
,
2
);
// just repeatedly delete point 2
}
}
TArray
<
FVector
>
Pts
=
{
FVector
(
0
,
0
,
0
),
FVector
(
0
,
0
,
0
)
};
TArray
<
FVector
>
Pts
=
{
FVector
(
0
,
0
,
0
),
FVector
(
0
,
0
,
0
)
};
...
@@ -1273,7 +1273,7 @@ bool UGPUInstancedLineComponent::RemoveAllEditorLines()
...
@@ -1273,7 +1273,7 @@ bool UGPUInstancedLineComponent::RemoveAllEditorLines()
bool
UGPUInstancedLineComponent
::
RemovePoint
(
int32
LineId
,
int32
PointId
)
bool
UGPUInstancedLineComponent
::
RemovePoint
(
int32
LineId
,
int32
PointId
)
{
{
TRACE_CPUPROFILER_EVENT_SCOPE
(
TEXT
(
"UGPUInstancedLineComponent::Remove
L
in
e
"
))
TRACE_CPUPROFILER_EVENT_SCOPE
(
TEXT
(
"UGPUInstancedLineComponent::Remove
Po
in
t
"
))
GPULineArray
&
Line
=
LineMap
[
LineId
];
GPULineArray
&
Line
=
LineMap
[
LineId
];
const
GPULineIndices
&
Indices
=
Line
[
PointId
];
const
GPULineIndices
&
Indices
=
Line
[
PointId
];
...
@@ -1341,7 +1341,7 @@ bool UGPUInstancedLineComponent::RemovePoint(int32 LineId, int32 PointId)
...
@@ -1341,7 +1341,7 @@ bool UGPUInstancedLineComponent::RemovePoint(int32 LineId, int32 PointId)
// todo
// todo
bool
UGPUInstancedLineComponent
::
RemovePoints
(
int32
LineId
,
int32
StartingPointId
,
int32
NumberOfPoints
)
bool
UGPUInstancedLineComponent
::
RemovePoints
(
int32
LineId
,
int32
StartingPointId
,
int32
NumberOfPoints
)
{
{
TRACE_CPUPROFILER_EVENT_SCOPE
(
TEXT
(
"UGPUInstancedLineComponent::Remove
Line
"
))
TRACE_CPUPROFILER_EVENT_SCOPE
(
TEXT
(
"UGPUInstancedLineComponent::Remove
Points
"
))
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment