fix: ResetFace() was called every tick (depending on options) even if not...

fix: ResetFace() was called every tick (depending on options) even if not needed, resulting in major performance penalty

Source/CharacterPlugin/Private/FaceAnimation/VHFaceAnimation.cpp

@@ -190,16 +190,16 @@ void UVHFaceAnimation::TickComponent(float DeltaTime, ELevelTick TickType,
 		LastFrameNr = FrameNr;
 
 		ApplyFrameData(FrameNr);
+		bIsFaceReset = false;
 	}
-	else
-	{
-		if (bResetFaceAfterFinish)
+	else if (bResetFaceAfterFinish && !bIsFaceReset)
 	{
 		//in case this is used together with a FacialExpression
 		//we have to do this, so that the right data is pulled from the 
 		// FacialExpression component every frame (especially before staring that actual animation)
 		ResetFace();
-		}
+
+		bIsFaceReset = false;
 	}
 }
 

Source/CharacterPlugin/Public/FaceAnimation/VHFaceAnimation.h

@@ -124,11 +124,13 @@ protected:
 	TMap<FString, FAnimationData> CachedAnimationData;
 
 	bool bCurrentlyPlaying = false;
+	/** Essentially indicates whether the face has not been reset i.e. whether it is considered 'dirty' */
+	bool bIsFaceReset = true;
 	float CurrentPlayTime = 0.0f;
 	float FadeFraction = 0.0f;
 	int LastFrameNr = 0;
 
-	UVHAnimInstance* AnimInstance;
+	UPROPERTY() UVHAnimInstance* AnimInstance;
 	bool UseMorphs = true;
 
 public: