WIP: #462_support_onboard_gpus

added 1 commit

• 03c46cb7 - Fixed cpplint.

Compare with previous version

By Ali Can Demiralp on 2018-07-23T17:42:37 (imported from GitLab)

added 1 commit

• 58141aad - Updated mock.

Compare with previous version

By Ali Can Demiralp on 2018-07-23T17:57:29 (imported from GitLab)

Codewise it looks totally fine for me.

However, I am unfortunately not quite sure what the aim of this issue is. I still get tons of GL_INVALID_OPERATION und GL_INVALID_ENUM errors for, e.g., the combustion demo on my laptop (ThinkPad T470s with an Intel HD Graphics 620 (GT2) as integrated graphics unit). Furthermore, the integration tests still fail due to a mismatch in the image similarity (sometimes a really small one, sometimes a significant one). Should those problems be (partially) solved with this issue? If so, I guess we need more changes. If not, please tell me and I'll give a thumbs up immediately.

By Andrea Bönsch on 2018-07-24T21:18:27 (imported from GitLab)

It seems to be due to: The said call is not used in any place. Interesting.

By Ali Can Demiralp on 2018-07-25T00:55:35 (imported from GitLab)

On my laptop, also textures cannot be rendered yet.

Yes, you are right that we want to develop a cutting-edge software. But not being able to show stuff on a laptop albeit that being (so far) only a small pain, would be contraproductive

By Jonathan Ehret on 2018-07-26T07:54:35 (imported from GitLab)

marked as a Work In Progress

By Ali Can Demiralp on 2018-07-26T13:25:40 (imported from GitLab)

Switched to WIP, I do not have an immediate solution since I cannot trace where glGetVertexAttribfv is getting called (static search says nowhere, including the gl lib).

By Ali Can Demiralp on 2018-07-26T13:28:34 (imported from GitLab)

changed title from WIP: #462_do_not_use_arb_extensions to WIP: #462_support_onboard_gpus

By Ali Can Demiralp on 2018-07-26T13:44:37 (imported from GitLab)