#473 resize companion window

added 18 commits

93ee153f...000b044d - 17 commits from branch master
8dcafee3 - Merge branch 'master' into feature/#473_resize_companion_window

Compare with previous version

By Jonathan Ehret on 2018-07-26T08:31:17 (imported from GitLab)

added 1 commit

ac242b16 - replace tabs by spaces

Compare with previous version

By Jonathan Ehret on 2018-07-26T08:32:08 (imported from GitLab)

@ademiralp This does not change the problem:

Furthermore, a lot of new warnings are thrown by OpenGL:

[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <tex> is not valid.
[10:37:36][warning] [gl::error] with message GL_INVALID_OPERATION error generated. <texture> does not refer to an existing texture object
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <tex> is not valid.
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <attachment> does not specify a valid attachment for the default framebuffer.
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <attachment> does not specify a valid attachment for the default framebuffer.
[10:37:36][warning] [gl::error] with message GL_INVALID_OPERATION error generated. <texture> does not refer to an existing texture object
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <tex> is not valid.
[10:37:36][warning] [gl::error] with message GL_INVALID_OPERATION error generated. <texture> does not refer to an existing texture object
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <tex> is not valid.
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <attachment> does not specify a valid attachment for the default framebuffer.
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <attachment> does not specify a valid attachment for the default framebuffer.
[10:37:36][warning] [gl::error] with message GL_INVALID_OPERATION error generated. <texture> does not refer to an existing texture object
[10:37:36][warning] [gl::error] with message GL_INVALID_ENUM error generated. <tex> is not valid.
[10:37:36][warning] [gl::error] with message GL_INVALID_OPERATION error generated. <texture> does not refer to an existing texture object

Please test the code you put out for a merge request and don't make me waste my time on trying to understand your code, which I then test and it doesn't work...

By Jonathan Ehret on 2018-07-26T08:39:18 (imported from GitLab)

Fixed. However not using the RenderTarget since the window RenderTarget is not associated with the backbuffer, and is an independent framebuffer whereas it actually is 1-1 with the backbuffer. Without this, we would still require a 'render to backbuffer' pass that is different than the 'blit pass' (which would take a single RenderTarget and a size).

Instead we should create a 1-1 association between the window RenderTarget and the gl::framebuffer(0). This should be a separate issue though.

By Ali Can Demiralp on 2018-07-26T15:25:33 (imported from GitLab)

Still getting lots of errors:

[10:52:42][info] An HMD is present so we use it
[10:52:42][warning] [gl::error] with message Buffer detailed info: Buffer object 3 (bound to NONE, usage hint is GL_STATIC_DRAW) will use VIDEO memory as the so
urce for buffer object operations.
[10:52:42][warning] [gl::error] with message Buffer detailed info: Buffer object 4 (bound to NONE, usage hint is GL_STATIC_DRAW) will use VIDEO memory as the so
urce for buffer object operations.
[10:52:42][warning] [gl::error] with message Buffer detailed info: Buffer object 5 (bound to NONE, usage hint is GL_STATIC_DRAW) will use VIDEO memory as the so
urce for buffer object operations.
[10:52:42][warning] [gl::error] with message Buffer detailed info: Buffer object 6 (bound to NONE, usage hint is GL_STATIC_DRAW) will use VIDEO memory as the so
urce for buffer object operations.
[10:52:42][info] Load Model: Q:/mb573713/dev/Project_Phoenix/resources/models/combustion/combustion_opt.stl
[==================================================] (100%)
[10:52:48][info] Finished Loading Model
[10:52:48][info] WARNING: Shininess values < 0.0 are not allowed, desired value of -1.07374e+08 has not been set!
[10:52:48][info] Load Model: Q:/mb573713/dev/Project_Phoenix/resources/models/combustion/data_box.stl
[==================================================] (100%)
[10:52:48][info] Finished Loading Model
[10:52:48][info] WARNING: Shininess values < 0.0 are not allowed, desired value of -1.07374e+08 has not been set!
[10:52:48][info] Load Model: Q:/mb573713/dev/Project_Phoenix/resources/models/cube/cube.obj
[==================================================] (100%)
[10:52:48][info] Finished Loading Model
[10:52:48][info] Load Model: Q:/mb573713/dev/Project_Phoenix/resources/models/cube/cube2.obj
[==================================================] (100%)
[10:52:48][info] Finished Loading Model
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 7 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the s
ource for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 8 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the s
ource for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 9 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the s
ource for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 10 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the
source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 11 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the
source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 12 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the
source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 13 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the
source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 14 (bound to NONE, usage hint is GL_DYNAMIC_DRAW) will use VIDEO memory as the
source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 1 (bound to GL_UNIFORM_BUFFER (0), and GL_UNIFORM_BUFFER_EXT, usage hint is GL_
DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 1 (bound to GL_UNIFORM_BUFFER (0), and GL_UNIFORM_BUFFER_EXT, usage hint is GL_
DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 1 (bound to GL_UNIFORM_BUFFER (0), and GL_UNIFORM_BUFFER_EXT, usage hint is GL_
DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 2 (bound to GL_UNIFORM_BUFFER (0), and GL_UNIFORM_BUFFER_EXT, usage hint is GL_
DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 2 (bound to GL_UNIFORM_BUFFER (0), and GL_UNIFORM_BUFFER_EXT, usage hint is GL_
DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations.
[10:52:48][warning] [gl::error] with message Buffer detailed info: Buffer object 2 (bound to GL_UNIFORM_BUFFER (0), and GL_UNIFORM_BUFFER_EXT, usage hint is GL_
DYNAMIC_DRAW) will use VIDEO memory as the source for buffer object operations.

Also the window is now 1200 px high, which is too much for most screens. The point of this ticket was, to scale down the image from the HMD, so everything the user sees is visible.

By Martin Bellgardt on 2018-07-31T08:54:36 (imported from GitLab)

These errors are however not a problem of this particular issue, but were existent already before, since we added the opengl debug callback, see #497

By Jonathan Ehret on 2018-07-31T09:14:43 (imported from GitLab)

Oh, ok. Still the issue at the end of my comment stands.

By Martin Bellgardt on 2018-07-31T11:25:04 (imported from GitLab)

Yes, I would back that up. So the companion window should fit on an HD screen, so not be higher than 1080. But @ademiralp as far I saw it last time, this should be possible by just changing the values, right?

By Jonathan Ehret on 2018-07-31T11:53:22 (imported from GitLab)