Merge pull request #188 from mattt/mattt/fix-connection-string-validation

Fix handling of invalid connection strings

common/lib/azure/storage/common/client_options.rb

@@ -347,7 +347,7 @@ module Azure::Storage::Common
       def parse_connection_string(connection_string)
         opts = {}
         connection_string.split(";").each do |i|
-          e = i.index("=")
+          e = i.index("=") || -1
           raise InvalidConnectionStringError, Azure::Storage::Common::Core::SR::INVALID_CONNECTION_STRING if e < 0 || e == i.length - 1
           key, value = i[0..e - 1], i[e + 1..i.length - 1]
           raise InvalidConnectionStringError, Azure::Storage::Common::Core::SR::INVALID_CONNECTION_STRING_BAD_KEY % key unless ClientOptions.connection_string_mapping.key? key

test/unit/blob/blob_service_test.rb

@@ -47,6 +47,16 @@ describe Azure::Storage::Blob::BlobService do
     subject.stubs(:call).returns(response)
   }
 
+  describe "#create_from_connection_string" do
+    let(:service) { Azure::Storage::Blob::BlobService }
+
+    it "returns nil for a valid connection string" do
+      assert_raises(Azure::Storage::Common::InvalidConnectionStringError) {
+        Azure::Storage::Blob::BlobService.create_from_connection_string("invalid")
+      }
+    end
+  end
+
   describe "#get_user_delegation_key" do
     let(:response_body) {
       '<?xml version="1.0" encoding="utf-8"?>