Skip to content
Snippets Groups Projects
Commit 38fe3888 authored by Darius Schneider's avatar Darius Schneider
Browse files

update ci pipeline to use newer gems

parent 07c85309
Branches
No related tags found
No related merge requests found
glob: '**/*.{html,text,js}{+*,}.erb'
exclude:
- '**/vendor/**/*'
EnableDefaultLinters: true
linters:
ErbSafety:
enabled: true
FinalNewline:
enabled: true
Rubocop:
enabled: true
rubocop_config:
inherit_from:
- .rubocop.yml
Layout/InitialIndentation:
Enabled: false
Layout/LineLength:
Enabled: false
Layout/TrailingEmptyLines:
Enabled: false
Layout/TrailingWhitespace:
Enabled: false
Naming/FileName:
Enabled: false
Style/FrozenStringLiteralComment:
Enabled: false
Lint/UselessAssignment:
Enabled: false
Rails/OutputSafety:
Enabled: false
...@@ -18,7 +18,7 @@ rubocop: ...@@ -18,7 +18,7 @@ rubocop:
- rails - rails
script: script:
- wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml"
- gem install rubocop:1.65.1 rubocop-capybara:2.21.0 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 --silent - gem install rubocop:1.70.0 rubocop-capybara:2.21.0 rubocop-minitest:0.36.0 rubocop-performance:1.23.1 rubocop-rails:2.29.0 --silent
- rubocop - rubocop
erb_lint: erb_lint:
...@@ -28,9 +28,9 @@ erb_lint: ...@@ -28,9 +28,9 @@ erb_lint:
- rails - rails
script: script:
- wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml"
- wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/erb-lint.yml" -O ".erb-lint.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/erb_lint.yml" -O ".erb_lint.yml"
- gem install rubocop:1.65.1 rubocop-capybara:2.21.0 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 erb_lint:0.6.0 --silent - gem install rubocop:1.70.0 rubocop-capybara:2.21.0 rubocop-minitest:0.36.0 rubocop-performance:1.23.1 rubocop-rails:2.29.0 erb_lint:0.8.0 --silent
- erblint --lint-all --allow-no-files true - erb_lint --lint-all --allow-no-files true
haml_lint: haml_lint:
stage: test stage: test
...@@ -40,7 +40,7 @@ haml_lint: ...@@ -40,7 +40,7 @@ haml_lint:
script: script:
- wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml"
- wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/haml-lint.yml" -O ".haml-lint.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/haml-lint.yml" -O ".haml-lint.yml"
- gem install rubocop:1.65.1 rubocop-capybara:2.21.0 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 haml_lint:0.58.0 --silent - gem install rubocop:1.70.0 rubocop-capybara:2.21.0 rubocop-minitest:0.36.0 rubocop-performance:1.23.1 rubocop-rails:2.29.0 haml_lint:0.59.0 --silent
- haml-lint - haml-lint
brakeman: brakeman:
...@@ -50,7 +50,7 @@ brakeman: ...@@ -50,7 +50,7 @@ brakeman:
- rails - rails
script: script:
- rm -f ./config/brakeman.yml ./config/brakeman.ignore - rm -f ./config/brakeman.yml ./config/brakeman.ignore
- gem install brakeman:6.2.1 --silent - gem install brakeman:7.0.0 --silent
- brakeman -A --except UnscopedFind - brakeman -A --except UnscopedFind
rails_test_all: rails_test_all:
......
...@@ -56,7 +56,7 @@ Metrics/BlockLength: ...@@ -56,7 +56,7 @@ Metrics/BlockLength:
# default is too restrictive, having some restriction incentivizes to split up overly large classes # default is too restrictive, having some restriction incentivizes to split up overly large classes
Metrics/ClassLength: Metrics/ClassLength:
CountAsOne: *array_hash_heredoc_method_call # default: [] CountAsOne: *array_hash_heredoc_method_call # default: []
Max: 200 # default: 100 Max: 300 # default: 100
Exclude: *test_config_db_gemspec_subconfig Exclude: *test_config_db_gemspec_subconfig
# default is too restrictive, allow higher complexity # default is too restrictive, allow higher complexity
...@@ -72,7 +72,7 @@ Metrics/MethodLength: ...@@ -72,7 +72,7 @@ Metrics/MethodLength:
# default is too restrictive, allow longer modules # default is too restrictive, allow longer modules
Metrics/ModuleLength: Metrics/ModuleLength:
CountAsOne: *array_hash_heredoc_method_call # default: [] CountAsOne: *array_hash_heredoc_method_call # default: []
Max: 200 # default: 100 Max: 300 # default: 100
Exclude: *test_config_db_gemspec_subconfig Exclude: *test_config_db_gemspec_subconfig
# long parameter lists add too much complexity, keyword args are named and thus more obvious what is expected, ignore them # long parameter lists add too much complexity, keyword args are named and thus more obvious what is expected, ignore them
......
...@@ -4,11 +4,11 @@ require: ...@@ -4,11 +4,11 @@ require:
- rubocop-performance - rubocop-performance
- rubocop-rails - rubocop-rails
# gem "rubocop", "1.65.1", require: false # gem "rubocop", "1.70.0", require: false
# gem "rubocop-capybara", "2.21.0", require: false # gem "rubocop-capybara", "2.21.0", require: false
# gem "rubocop-minitest", "0.35.1", require: false # gem "rubocop-minitest", "0.36.0", require: false
# gem "rubocop-performance", "1.21.1", require: false # gem "rubocop-performance", "1.23.1", require: false
# gem "rubocop-rails", "2.25.1", require: false # gem "rubocop-rails", "2.29.0", require: false
AllCops: AllCops:
NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed
......
require: require:
- rubocop-performance - rubocop-performance
# gem 'rubocop', '1.65.1', require: false # gem 'rubocop', '1.70.0', require: false
# gem 'rubocop-performance', '1.21.1', require: false # gem 'rubocop-performance', '1.23.1', require: false
AllCops: AllCops:
NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed
...@@ -45,7 +45,7 @@ Metrics/BlockLength: ...@@ -45,7 +45,7 @@ Metrics/BlockLength:
# default is too restrictive, having some restriction incentivizes to split up overly large classes # default is too restrictive, having some restriction incentivizes to split up overly large classes
Metrics/ClassLength: Metrics/ClassLength:
CountAsOne: *array_hash_heredoc_method_call # default: [] CountAsOne: *array_hash_heredoc_method_call # default: []
Max: 200 # default: 100 Max: 300 # default: 100
Exclude: *test_config_db Exclude: *test_config_db
# default is too restrictive, allow higher complexity # default is too restrictive, allow higher complexity
...@@ -61,7 +61,7 @@ Metrics/MethodLength: ...@@ -61,7 +61,7 @@ Metrics/MethodLength:
# default is too restrictive, allow longer modules # default is too restrictive, allow longer modules
Metrics/ModuleLength: Metrics/ModuleLength:
CountAsOne: *array_hash_heredoc_method_call # default: [] CountAsOne: *array_hash_heredoc_method_call # default: []
Max: 200 # default: 100 Max: 300 # default: 100
Exclude: *test_config_db Exclude: *test_config_db
# long parameter lists add too much complexity, keyword args are named and thus more obvious what is expected, ignore them # long parameter lists add too much complexity, keyword args are named and thus more obvious what is expected, ignore them
......
require: require:
- rubocop-minitest - rubocop-minitest
# gem 'rubocop', '1.65.1', require: false # gem 'rubocop', '1.70.0', require: false
# gem 'rubocop-minitest', '0.35.1', require: false # gem 'rubocop-minitest', '0.36.0', require: false
AllCops: AllCops:
NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed
......
require: require:
- rubocop-rails - rubocop-rails
# gem 'rubocop', '1.65.1', require: false # gem 'rubocop', '1.70.0', require: false
# gem 'rubocop-rails', '2.25.1', require: false # gem 'rubocop-rails', '2.29.0', require: false
AllCops: AllCops:
NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed
...@@ -11,7 +11,7 @@ AllCops: ...@@ -11,7 +11,7 @@ AllCops:
# BEGIN Rails # BEGIN Rails
# file paths should be built with arguments instead of a single string # file paths should be built with arguments instead of a single string
Rails/ApplicationController: Rails/ApplicationController:
Exclude: ['app/controllers/api/**/*', 'app/controllers/a_p_i/**/*'] # exclude API namespace, but not others (convention) Exclude: ['app/controllers/api/**/*', 'app/controllers/a_p_i/**/*'] # exclude API namespace, but not others (ITC convention)
# exclude migrations since non-ApplicationRecord behavior might be desired # exclude migrations since non-ApplicationRecord behavior might be desired
Rails/ApplicationRecord: Rails/ApplicationRecord:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment