Skip to content
Snippets Groups Projects
Commit 53063364 authored by Leah Tacke genannt Unterberg's avatar Leah Tacke genannt Unterberg
Browse files

minor changes to improve superset asset identifier consistency

parent f357353f
Branches
No related tags found
No related merge requests found
......@@ -129,9 +129,12 @@ class SupersetMitMDatasetBundle(SupersetAssetBundle):
datasource_bundle=self.datasource_bundle,
visualization_bundle=visualization_bundle)
def to_import(self, meta_data_type: MetadataType = MetadataType.Asset) -> SupersetMitMDatasetImport:
def to_import(self, metadata_type: MetadataType = MetadataType.MitMDataset) -> SupersetMitMDatasetImport:
base_assets = mk_assets_import(databases=[self.datasource_bundle.database],
datasets=self.datasource_bundle.datasets,
charts=self.visualization_bundle.charts,
dashboards=self.visualization_bundle.dashboards)
return mk_mitm_dataset_import(mitm_datasets=[self.mitm_dataset], base_assets=base_assets)
dashboards=self.visualization_bundle.dashboards,
metadata_type=metadata_type)
return mk_mitm_dataset_import(mitm_datasets=[self.mitm_dataset],
base_assets=base_assets,
metadata_type=metadata_type)
......@@ -5,6 +5,7 @@ import pydantic
from mitm_tooling.transformation.superset.definitions import DatasetIdentifierMap, \
DatabaseIdentifier, MitMDatasetIdentifier, BaseSupersetDefinition, DashboardIdentifier, SupersetMitMDatasetDef
from mitm_tooling.utilities.python_utils import deep_merge_dicts
VizDashboardIdentifierMap = dict[str, DashboardIdentifier]
VizCollectionIdentifierMap = dict[str, VizDashboardIdentifierMap]
......@@ -42,3 +43,7 @@ class MitMDatasetIdentifierBundle(DatasourceIdentifierBundle):
viz_id_map={
'default': {dash.dashboard_title: dash for dash in
(mitm_dataset.dashboards or [])}})
def with_visualizations(self, *viz_id_maps: VizCollectionIdentifierMap) -> Self:
merged_viz_id_map = deep_merge_dicts(self.viz_id_map, *viz_id_maps)
return self.model_copy(update=dict(viz_id_map=merged_viz_id_map), deep=True)
\ No newline at end of file
......@@ -16,6 +16,7 @@ def mk_assets_import(databases: list[SupersetDatabaseDef] = None,
def mk_mitm_dataset_import(mitm_datasets: list[SupersetMitMDatasetDef],
base_assets: SupersetAssetsImport) -> SupersetMitMDatasetImport:
base_assets: SupersetAssetsImport,
metadata_type: MetadataType = MetadataType.MitMDataset) -> SupersetMitMDatasetImport:
return SupersetMitMDatasetImport(mitm_datasets=mitm_datasets, base_assets=base_assets,
metadata=mk_metadata(MetadataType.MitMDataset))
metadata=mk_metadata(metadata_type))
[project]
name = "mitm-tooling"
version = "0.5.1"
version = "0.5.2"
description = ""
authors = [{ name = "Leah Tacke genannt Unterberg", email = "l.tgu@pads.rwth-aachen.de" }]
requires-python = ">=3.11,<3.14"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment