Draft: Fortran Support

Testing using level 2

Disqualified Tests:

• Passing NULL/MPI_REQUEST_NULL causes compile errors in Fortran, disqualifying InvalidParam tests that do this
  • Disqualifies 17 tests (lvl1) / 136 (lvl2)
• A lot of tests are currently removed due to datatypes, i.e., MPI C types that do not exist / are not implemented yet for Fortran
  • No effect on lvl1, as only MPI_INT and MPI_DOUBLE are used / 501 disqualified (lvl2)

Unfixable, but not disqualified:

• InvalidParam-Status-mpi_recv-002: MPI_STATUSES_IGNORE rejected by compiler, different rank than expected
  • Error class does not exist for Fortran. Disqualifies 1 test (lvl1) / 16 (lvl2)

MPI Issues:

• https://github.com/open-mpi/ompi/issues/9534 - Causes issues with Precv_Init / Psend_init. Need recent OpenMPI version to avoid this
• https://github.com/open-mpi/ompi/pull/13308 - Bug in OpenMPI-git causes compilation failure as well

Types are translated from C to Fortran where applicable, though currently only for MPI_INT -> MPI_INTEGER, MPI_DOUBLE -> MPI_DOUBLE_PRECISION, MPI_C_BOOL -> MPI_LOGICAL as most Fortran MPI types are optional. Tests are formatted using fprettify (available from pip, added to Pipfile).

Common Issues encountered:

• MPI does not differentiate between bool and int, but does between integer and logical.
  • Workaround: Use bool where applicable in C code, then translate to logical
• Different integer size expectations cause compilation failures (no automatic extension)
  • Workaround: During parsing of apis.json, save the integer width, and perform explicit widening if needed.
• C usage of address-of-integer as a one-dimensional array does not work in Fortran
  • Workaround: Replace uses thereof with proper arrays
• Array Indexing starts at 1
  • Workaround: Implement explicit indexing to match C

MPI-BugBench bugs (since remembering to write them down):

• Deadlock in CallOrdering-mpi_improbe-mpi_send-001, wrong parameter used as flag
  • Note: Deadlock also happens in InvalidParam-flag-mpi_iprobe-002, but intended? (not_allocated flag is not waited on, but the "normal" one)

scripts/tools/must.py

@@ -20,20 +20,20 @@ def must_filter(line, process):
 
 class V18(AbstractTool):
     def identify(self):
-        return "MUST v1.9.2 wrapper"
+        return "MUST v1.11.0 wrapper"
 
     def ensure_image(self):
         AbstractTool.ensure_image(self, "-x must")
 
     def build(self, rootdir, cached=True):
-        if cached and os.path.exists("/MBB-builds/MUST192/bin/mustrun"):
+        if cached and os.path.exists("/MBB-builds/MUST1_11_0/bin/mustrun"):
             os.environ['PATH'] = os.environ['PATH'] + \
-                ":/MBB-builds/MUST192/bin/"
-            os.environ['OMPI_CC'] = "clang-14"
+                ":/MBB-builds/MUST1_11_0/bin/"
+            os.environ['OMPI_CC'] = "clang-19"
             return
 
         # MUST sometimes fails when reinstalling over the same dir
-        subprocess.run(f"rm -rf /MBB-builds/MUST192", shell=True, check=True)
+        subprocess.run(f"rm -rf /MBB-builds/MUST1_11_0", shell=True, check=True)
 
         # Build it
         here = os.getcwd()  # Save where we were
@@ -41,14 +41,13 @@ class V18(AbstractTool):
             f"rm -rf /tmp/build-must ; mkdir /tmp/build-must", shell=True, check=True)
         os.chdir("/tmp/build-must")
         subprocess.run(
-            f"wget https://hpc.rwth-aachen.de/must/files/MUST-v1.9.2.tar.gz", shell=True, check=True)
+            f"wget https://hpc.rwth-aachen.de/must/files/MUST-v1.11.0.tar.gz", shell=True, check=True)
         subprocess.run(f"tar xfz MUST-*.tar.gz", shell=True, check=True)
         subprocess.run(f"mkdir -p /tmp/build-must/build",
                        shell=True, check=True)
         os.chdir("/tmp/build-must/build")
 
-        subprocess.run(f"CC=$(which gcc) CXX=$(which gcc++) cmake ../MUST-v1.9.2 -DCMAKE_INSTALL_PREFIX=/MBB-builds/MUST192 -DCMAKE_BUILD_TYPE=Release  -DENABLE_FORTRAN=OFF -DENABLE_TYPEART=On", shell=True, check=True)
-        # subprocess.run(f"CC=$(which clang) CXX=$(which clang++) cmake ../MUST-v1.9.2 -DCMAKE_INSTALL_PREFIX=/MBB-builds/MUST192 -DCMAKE_BUILD_TYPE=Release  -DENABLE_FORTRAN=OFF -DENABLE_TYPEART=On", shell=True, check=True)
+        subprocess.run(f"CC=$(which gcc) CXX=$(which gcc++) FC=$(which gfortran) cmake ../MUST-v1.11.0 -DCMAKE_INSTALL_PREFIX=/MBB-builds/MUST1_11_0 -DCMAKE_BUILD_TYPE=Release  -DENABLE_FORTRAN=ON -DENABLE_TYPEART=On", shell=True, check=True)
         subprocess.run(f"make -j$(nproc) install VERBOSE=1",
                        shell=True, check=True)
         subprocess.run(
@@ -59,22 +58,31 @@ class V18(AbstractTool):
         os.chdir(here)
 
     def setup(self):
-        os.environ['PATH'] = os.environ['PATH'] + ":/MBB-builds/MUST192/bin/"
+        os.environ['PATH'] = os.environ['PATH'] + ":/MBB-builds/MUST1_11_0/bin/"
         os.environ['OMPI_ALLOW_RUN_AS_ROOT'] = "1"
         os.environ['OMPI_ALLOW_RUN_AS_ROOT_CONFIRM'] = "1"
 
     def run(self, execcmd, filename, binary, id, number, timeout, batchinfo, loglevel=logging.INFO):
         cachefile = f'{binary}_{id}'
 
+        print(filename)
+        if filename.endswith(".c"):
+            lang_args = "--must:language c --must:typeart"
+        else:
+            # Switch to --must:language fortran when MUST supports Fortran 2008. Until then: Workaround using MPICH and --must:language C (Internal C API call)
+            lang_args = "--must:language c"
+
         execcmd = re.sub(
-            "mpirun", "mustrun --must:distributed --must:typeart --must:output json", execcmd)
+            "mpirun", f"mustrun --must:distributed {lang_args} --must:output json", execcmd)
         execcmd = re.sub('\${EXE}', f'./{binary}', execcmd)
         execcmd = re.sub('\$zero_buffer', "", execcmd)
         execcmd = re.sub('\$infty_buffer', "", execcmd)
 
         with tempfile.TemporaryDirectory() as tmpdirname:
+            _, file_ext = os.path.splitext(filename)
+            compiler = "typeart-mpicc" if file_ext == ".c" else "mpif90 -ffree-line-length-0 -ffixed-line-length-0"
             ran = self.run_cmd(
-                buildcmd=f"typeart-mpicc -g -fPIC {filename} -o {tmpdirname}/{binary} -L/MBB-builds/MUST192/lib -lpnmpi",
+                buildcmd=f"{compiler} -g -fPIC {filename} -o {tmpdirname}/{binary} -L/MBB-builds/MUST1_11_0/lib -lpnmpi",
                 execcmd=execcmd,
                 cachefile=cachefile,
                 filename=filename,