Draft: Fortran Support

Testing using level 2

Disqualified Tests:

• Passing NULL/MPI_REQUEST_NULL causes compile errors in Fortran, disqualifying InvalidParam tests that do this
  • Disqualifies 17 tests (lvl1) / 136 (lvl2)
• A lot of tests are currently removed due to datatypes, i.e., MPI C types that do not exist / are not implemented yet for Fortran
  • No effect on lvl1, as only MPI_INT and MPI_DOUBLE are used / 501 disqualified (lvl2)

Unfixable, but not disqualified:

• InvalidParam-Status-mpi_recv-002: MPI_STATUSES_IGNORE rejected by compiler, different rank than expected
  • Error class does not exist for Fortran. Disqualifies 1 test (lvl1) / 16 (lvl2)

MPI Issues:

• https://github.com/open-mpi/ompi/issues/9534 - Causes issues with Precv_Init / Psend_init. Need recent OpenMPI version to avoid this
• https://github.com/open-mpi/ompi/pull/13308 - Bug in OpenMPI-git causes compilation failure as well

Types are translated from C to Fortran where applicable, though currently only for MPI_INT -> MPI_INTEGER, MPI_DOUBLE -> MPI_DOUBLE_PRECISION, MPI_C_BOOL -> MPI_LOGICAL as most Fortran MPI types are optional. Tests are formatted using fprettify (available from pip, added to Pipfile).

Common Issues encountered:

• MPI does not differentiate between bool and int, but does between integer and logical.
  • Workaround: Use bool where applicable in C code, then translate to logical
• Different integer size expectations cause compilation failures (no automatic extension)
  • Workaround: During parsing of apis.json, save the integer width, and perform explicit widening if needed.
• C usage of address-of-integer as a one-dimensional array does not work in Fortran
  • Workaround: Replace uses thereof with proper arrays
• Array Indexing starts at 1
  • Workaround: Implement explicit indexing to match C

MPI-BugBench bugs (since remembering to write them down):

• Deadlock in CallOrdering-mpi_improbe-mpi_send-001, wrong parameter used as flag
  • Note: Deadlock also happens in InvalidParam-flag-mpi_iprobe-002, but intended? (not_allocated flag is not waited on, but the "normal" one)

scripts/Infrastructure/TemplateFactory.py

@@ -223,7 +223,7 @@ def get_type_buffers(tm, type_1, type_2, size_1, size_2):
     else:
         assert type_1 in user_defined_types
         buf_name_1, type_1_variable = get_buffer_for_usertype(type_1, tm, "MPICALL", size_1)
-    tm.register_instruction(str(get_free_by_name(buf_name_1)))
+    tm.register_instruction(get_free_by_name(buf_name_1))
     if type_2 in predefined_types:
         type_2_variable = type_2
         buf_alloc_call = get_buffer_for_type(type_2, size_2)
@@ -233,7 +233,7 @@ def get_type_buffers(tm, type_1, type_2, size_1, size_2):
     else:
         assert type_2 in user_defined_types
         buf_name_2, type_2_variable = get_buffer_for_usertype(type_2, tm, "MPICALL", size_2)
-    tm.register_instruction(str(get_free_by_name(buf_name_2)))
+    tm.register_instruction(get_free_by_name(buf_name_2))
     return type_1_variable, buf_name_1, type_2_variable, buf_name_2
 
 
@@ -380,13 +380,13 @@ def get_send_recv_template(send_func: str = "mpi_isend", recv_func: str | typing
     if send_func in ["mpi_bsend", "mpi_ibsend", "mpi_bsend_init"]:
         tm.add_stack_variable("int", "freed_size")
         tm.register_instruction(MPICallFactory.mpi_buffer_detach("mpi_buf", "&freed_size"), identifier="FREE")
-        tm.register_instruction(str(get_free_by_name("mpi_buf")), identifier="FREE")
+        tm.register_instruction(get_free_by_name("mpi_buf"), identifier="FREE")
 
     tm.register_instruction(cf.get_buffer_free(), identifier="FREE")
 
     if send_func in sendrecv_funcs:
         # spilt send and recv buf
-        tm.register_instruction(str(get_free_by_name("recv_buf")), identifier="FREE")
+        tm.register_instruction(get_free_by_name("recv_buf"), identifier="FREE")
 
     if send_func in persistent_send_funcs:
         tm.register_instruction(CorrectMPICallFactory.mpi_request_free(), rank_to_execute=1,identifier="FREE")