Fix ITAC and MUST parsing of internal MPI crashes, they should not count as TP

scripts/tools/itac.py

@@ -95,6 +95,13 @@ class Tool(AbstractTool):
         if re.search('ERROR: Giving up now...', output):
             return 'failure'
         
+        # if we arrive here, nothing relevant has been detected, MPI might just crashed internally, then return OK
+        if re.search('Fatal error in internal_Comm_size', output):
+            return 'OK'
+        
+        if re.search(r'Attempting to use an MPI routine \(PMPI_Comm_size\) before initializing or after finalizing MPICH', output):
+            return 'OK'
+
         print (f">>>>[ INCONCLUSIVE ]>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> (itac/{cachefile})")
         print(output)
         print ("<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<")

scripts/tools/must.py

@@ -155,15 +155,6 @@ class V18(AbstractTool):
         if re.search('Compilation of .*? raised an error \(retcode: ', output):
             return 'UNIMPLEMENTED'
 
-        if re.search('caught MPI error', output):
-            return 'mpierr'
-
-        if re.search('Error', output):
-            return 'mpierr'
-        
-        if re.search('MPI_ABORT', output):
-            return 'mpierr'
-
         if re.search('YOUR APPLICATION TERMINATED WITH THE EXIT STRING: Segmentation fault', output):
             return 'segfault'
         if re.search('caught signal nr 11', output) or re.search('caught signal nr 6', output):
@@ -181,6 +172,14 @@ class V18(AbstractTool):
         if os.path.exists(f'{cachefile}.timeout') or os.path.exists(f'{logs_dir}/must/{cachefile}.timeout'):
             return 'timeout'
         
+        if re.search('caught MPI error', output):
+            # if we arrive here we, then MUST just found an MPI error, but did not detect anything, so we return 'OK'
+            return 'OK'
+        
+        if re.search('Fatal error in internal_Comm_size', output):
+            # if we arrive here, nothing relevant has been detected, MPI just crashed internally
+            return 'OK'
+
         print (f">>>>[ INCONCLUSIVE ]>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> ({self.identify()}/{cachefile})")
         print(output)
         print ("<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<")