Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
Runner Mirror
Manage
Activity
Members
Plan
Wiki
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Package registry
Model registry
Operate
Terraform modules
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Adrian Schmitz
Runner Mirror
Commits
52434b6e
Commit
52434b6e
authored
1 year ago
by
Adrian Schmitz
Browse files
Options
Downloads
Patches
Plain Diff
HOTFIX: remove redundant and broken jobid callbacks for slurm
Signed-off-by:
Adrian Schmitz
<
a.schmitz@itc.rwth-aachen.de
>
parent
98183df1
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
core/modes/slurm/shared.py
+1
-2
1 addition, 2 deletions
core/modes/slurm/shared.py
with
1 addition
and
2 deletions
core/modes/slurm/shared.py
+
1
−
2
View file @
52434b6e
...
@@ -53,7 +53,7 @@ class SingleSlurmJobAcrossStages(Slurm, ABC):
...
@@ -53,7 +53,7 @@ class SingleSlurmJobAcrossStages(Slurm, ABC):
logging
.
info
(
f
'
Using slurm_job_id=
{
self
.
slurm_job_id
}
, could find
{
self
.
slurm_jobid_file
}
'
)
logging
.
info
(
f
'
Using slurm_job_id=
{
self
.
slurm_job_id
}
, could find
{
self
.
slurm_jobid_file
}
'
)
tmp_dir_srun_out
=
self
.
executor
.
management_handler
(
helper_script
=
f
"
{
self
.
job
.
scripts_path
}
/runHelper.sh
"
,
tmp_dir_srun_out
=
self
.
executor
.
management_handler
(
helper_script
=
f
"
{
self
.
job
.
scripts_path
}
/runHelper.sh
"
,
wrapper_add
=
f
'
--jobid
{
self
.
slurm_job_id
}
/usr/bin/printenv TMP
'
).
split
(
'
\n
'
)
wrapper_add
=
f
'
/usr/bin/printenv TMP
'
).
split
(
'
\n
'
)
logging
.
debug
(
f
'
srun tmp_dir output (unfitered):
{
tmp_dir_srun_out
}
'
)
logging
.
debug
(
f
'
srun tmp_dir output (unfitered):
{
tmp_dir_srun_out
}
'
)
ignores
=
[
'
error
'
,
'
slurmstepd
'
]
ignores
=
[
'
error
'
,
'
slurmstepd
'
]
self
.
tmp_dir
=
[
x
for
x
in
tmp_dir_srun_out
if
all
(
s
not
in
x
for
s
in
ignores
)]
self
.
tmp_dir
=
[
x
for
x
in
tmp_dir_srun_out
if
all
(
s
not
in
x
for
s
in
ignores
)]
...
@@ -69,7 +69,6 @@ class SingleSlurmJobAcrossStages(Slurm, ABC):
...
@@ -69,7 +69,6 @@ class SingleSlurmJobAcrossStages(Slurm, ABC):
additional_env
.
append
(
f
"
{
k
}
=
{
v
}
"
)
additional_env
.
append
(
f
"
{
k
}
=
{
v
}
"
)
if
len
(
additional_env
)
!=
0
:
if
len
(
additional_env
)
!=
0
:
parameters
+=
f
'
--export=
'
+
"
,
"
.
join
(
additional_env
)
parameters
+=
f
'
--export=
'
+
"
,
"
.
join
(
additional_env
)
parameters
+=
f
'
--jobid=
{
self
.
slurm_job_id
}
'
return
parameters
return
parameters
def
get_simple_run_wrapper
(
self
):
def
get_simple_run_wrapper
(
self
):
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment