From 9039d2d8b36552b35c76ce561e2584d08850e0d0 Mon Sep 17 00:00:00 2001
From: "jonathan.ehret" <ehret@vr.rwth-aachen.de>
Date: Sun, 1 Oct 2023 22:08:31 +0200
Subject: [PATCH] improvement of logging when validating phases

---
 Source/StudyFrameworkPlugin/Private/SFStudyPhase.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Source/StudyFrameworkPlugin/Private/SFStudyPhase.cpp b/Source/StudyFrameworkPlugin/Private/SFStudyPhase.cpp
index e615134..c46fb90 100644
--- a/Source/StudyFrameworkPlugin/Private/SFStudyPhase.cpp
+++ b/Source/StudyFrameworkPlugin/Private/SFStudyPhase.cpp
@@ -93,13 +93,18 @@ bool USFStudyPhase::PhaseValid() const
 			//what to actually do when more than one factor wants that???
 			FSFUtils::OpenMessageBox(
 				"[USFStudyPhase::PhaseValid] " + Factor->FactorName + " in phase " + PhaseName +
-				" is already the second enBlock factor, how should that work? If you know, implement ;-)", true);
+				" is already the second enBlock factor, \"nested\" enBlock factors are not supported since they don't seem needed", true);
 			return false;
 		}
 
 		NrNonCombinedFactors += (Factor->bNonCombined ? 1 : 0);
 	}
 
+	if (NrEnBlockFactors + NrInOrderFactors > 1)
+	{
+		FSFLoggingUtils::Log("[USFStudyPhase::PhaseValid] there is a \"nested\" inOrder factor, globally its levels will not be in order but per level of the prior inOrder/enBlock factor.");
+	}
+
 	if (NrNonCombinedFactors == Factors.Num())
 	{
 		FSFUtils::OpenMessageBox(
-- 
GitLab