From 30d4df7c6529cdfcbaf2a0738b8fcc3b8438aa6a Mon Sep 17 00:00:00 2001
From: David Gilbert <gilbert@vr.rwth-aachen.de>
Date: Thu, 14 Mar 2024 11:02:13 +0100
Subject: [PATCH] doc(navigation): Documents collision overlap trace in
 CollisionHandlingMovement

---
 .../Private/Pawn/Navigation/CollisionHandlingMovement.cpp     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Source/RWTHVRToolkit/Private/Pawn/Navigation/CollisionHandlingMovement.cpp b/Source/RWTHVRToolkit/Private/Pawn/Navigation/CollisionHandlingMovement.cpp
index a13dd015..b565b58a 100644
--- a/Source/RWTHVRToolkit/Private/Pawn/Navigation/CollisionHandlingMovement.cpp
+++ b/Source/RWTHVRToolkit/Private/Pawn/Navigation/CollisionHandlingMovement.cpp
@@ -342,6 +342,10 @@ TOptional<FVector> UCollisionHandlingMovement::GetOverlapResolveDirection() cons
 {
 	TArray<UPrimitiveComponent*> OverlappingComponents;
 	TArray<TEnumAsByte<EObjectTypeQuery>> traceObjectTypes;
+
+	// Ideally we would overlap with ECC_Visibility, but there is no object type this can be converted to that I know
+	// of. This returns everything, even triggers etc that are *not* visible, which is why we further check for a
+	// visibility trace and blocking hits.
 	traceObjectTypes.Add(EObjectTypeQuery::ObjectTypeQuery_MAX);
 
 	UKismetSystemLibrary::CapsuleOverlapComponents(GetWorld(), CapsuleColliderComponent->GetComponentLocation(),
-- 
GitLab