From b5f131981149b01e2fbb0e9dd9c1635e5f442e9b Mon Sep 17 00:00:00 2001
From: jwendt <wendt@vr.rwth-aachen.de>
Date: Thu, 19 Jul 2018 17:28:33 +0200
Subject: [PATCH] small refactoring to desktop navigation behavior

#463
---
 .../src/desktop_navigation_behavior.cpp       | 30 +++++++------------
 1 file changed, 10 insertions(+), 20 deletions(-)

diff --git a/demos/combustion_demo/src/desktop_navigation_behavior.cpp b/demos/combustion_demo/src/desktop_navigation_behavior.cpp
index 55e1a74e..661c7d9d 100644
--- a/demos/combustion_demo/src/desktop_navigation_behavior.cpp
+++ b/demos/combustion_demo/src/desktop_navigation_behavior.cpp
@@ -75,25 +75,15 @@ void DesktopNavigationBehavior::OnMouseMove(int x, int y) {
 
 void DesktopNavigationBehavior::OnMouseButton(phx::Mouse::ButtonId id,
                                               phx::Mouse::ButtonEvent event) {
-  if (event == phx::Mouse::BUTTON_PRESSED) {
-    if (id == phx::Mouse::LEFT_BUTTON) {
-      rotation_mode_ = true;
-    }
-    if (id == phx::Mouse::MIDDLE_BUTTON) {
-      strafe_mode_ = true;
-    }
-    if (id == phx::Mouse::RIGHT_BUTTON) {
-      translation_mode_ = true;
-    }
-  } else {
-    if (id == phx::Mouse::LEFT_BUTTON) {
-      rotation_mode_ = false;
-    }
-    if (id == phx::Mouse::MIDDLE_BUTTON) {
-      strafe_mode_ = false;
-    }
-    if (id == phx::Mouse::RIGHT_BUTTON) {
-      translation_mode_ = false;
-    }
+  bool value_to_set = (event == phx::Mouse::BUTTON_PRESSED);
+
+  if (id == phx::Mouse::LEFT_BUTTON) {
+    rotation_mode_ = value_to_set;
+  }
+  if (id == phx::Mouse::MIDDLE_BUTTON) {
+    strafe_mode_ = value_to_set;
+  }
+  if (id == phx::Mouse::RIGHT_BUTTON) {
+    translation_mode_ = value_to_set;
   }
 }
-- 
GitLab