From 7c32877dc0d1cbf542d14b1910fdf81432344f59 Mon Sep 17 00:00:00 2001 From: Darius Schneider <schneider@itc.rwth-aachen.de> Date: Wed, 2 Oct 2024 23:54:56 +0200 Subject: [PATCH] rubocop --- rails/gitlab-ci.yml | 7 ++++--- rails/rubocop.yml | 10 ++++++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/rails/gitlab-ci.yml b/rails/gitlab-ci.yml index 7b48fa6..2c9f868 100644 --- a/rails/gitlab-ci.yml +++ b/rails/gitlab-ci.yml @@ -18,7 +18,7 @@ rubocop: - rails script: - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml" - - gem install rubocop:1.65.1 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 --silent + - gem install rubocop:1.65.1 rubocop-capybara:2.21.0 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 --silent - rubocop erb_lint: @@ -29,7 +29,7 @@ erb_lint: script: - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/erb-lint.yml" -O ".erb-lint.yml" - - gem install rubocop:1.65.1 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 erb_lint:0.6.0 --silent + - gem install rubocop:1.65.1 rubocop-capybara:2.21.0 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 erb_lint:0.6.0 --silent - erblint --lint-all --allow-no-files true haml_lint: @@ -38,8 +38,9 @@ haml_lint: tags: - rails script: + - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/rubocop.yml" -O ".rubocop.yml" - wget --quiet "https://git-ce.rwth-aachen.de/noc-public/noc-netze-gitlab-cicd/-/raw/main/rails/haml-lint.yml" -O ".haml-lint.yml" - - gem install rubocop:1.65.1 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 haml_lint:0.58.0 --silent + - gem install rubocop:1.65.1 rubocop-capybara:2.21.0 rubocop-minitest:0.35.1 rubocop-performance:1.21.1 rubocop-rails:2.25.1 haml_lint:0.58.0 --silent - haml-lint brakeman: diff --git a/rails/rubocop.yml b/rails/rubocop.yml index 28078cf..b6386a4 100644 --- a/rails/rubocop.yml +++ b/rails/rubocop.yml @@ -1,12 +1,14 @@ require: + - rubocop-capybara - rubocop-minitest - rubocop-performance - rubocop-rails -# gem 'rubocop', '1.65.1', require: false -# gem 'rubocop-minitest', '0.35.1', require: false -# gem 'rubocop-performance', '1.21.1', require: false -# gem 'rubocop-rails', '2.25.1', require: false +# gem "rubocop", "1.65.1", require: false +# gem "rubocop-capybara", "2.21.0", require: false +# gem "rubocop-minitest", "0.35.1", require: false +# gem "rubocop-performance", "1.21.1", require: false +# gem "rubocop-rails", "2.25.1", require: false AllCops: NewCops: enable # pending cops get enabled by default and must be disabled by hand, if needed -- GitLab