From 7193d03c9ac5f51700f660345a344cd9fb46e7f9 Mon Sep 17 00:00:00 2001 From: Darius Schneider <schneider@itc.rwth-aachen.de> Date: Tue, 15 Apr 2025 14:28:59 +0200 Subject: [PATCH] added exception for ItcGemRubocop/DevelopmentHosts for rubocop:disable comments --- rails/rubocop/rubocop-base.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rails/rubocop/rubocop-base.yml b/rails/rubocop/rubocop-base.yml index 5e471ae..cb2bc50 100644 --- a/rails/rubocop/rubocop-base.yml +++ b/rails/rubocop/rubocop-base.yml @@ -127,6 +127,7 @@ Rails/SkipsModelValidations: # BEGIN Style # prevent getting around most cops, but allow a few that may be impossible to resolve otherwise, f.e.: +# ItcGemRubocop/DevelopmentHosts: allow usage of different `config.hosts` config in development, if needed # ItcGemRubocop/NocPortalRz: allow usage of string that contains `"noc-portal.rz.rwth-aachen.de"` if really needed # Lint/UnusedMethodArgument: subclasses that are passed unused keyword args, but not using them must be allowed # Naming/PredicateName: allow DSL style methods like Rails 'has_one' @@ -137,7 +138,7 @@ Rails/SkipsModelValidations: # Rails/ThreeStateBooleanColumn: allow usage of three-state boolean columns, it may be an STI table Style/DisableCopsWithinSourceCodeDirective: Enabled: true - AllowedCops: ['ItcGemRubocop/NocPortalRz', 'Lint/UnusedMethodArgument', 'Naming/PredicateName', 'Naming/VariableNumber', 'Rails/CreateTableWithTimestamps', 'Rails/DangerousColumnNames', 'Rails/NegateInclude', 'Rails/ThreeStateBooleanColumn'] + AllowedCops: ['ItcGemRubocop/DevelopmentHosts', 'ItcGemRubocop/NocPortalRz', 'Lint/UnusedMethodArgument', 'Naming/PredicateName', 'Naming/VariableNumber', 'Rails/CreateTableWithTimestamps', 'Rails/DangerousColumnNames', 'Rails/NegateInclude', 'Rails/ThreeStateBooleanColumn'] # documentation of classes in migrations and tests is not needed Style/Documentation: -- GitLab