From c13f2ab5f4a4bf0d356cf78f3e255f48fc587802 Mon Sep 17 00:00:00 2001
From: "@akhil.gunda" <gunda.akhil1@gmail.com>
Date: Fri, 24 Jan 2025 09:22:02 +0100
Subject: [PATCH] changes made to modify porosity estimation

---
 heatpipe.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/heatpipe.py b/heatpipe.py
index 499984f..a957054 100644
--- a/heatpipe.py
+++ b/heatpipe.py
@@ -117,10 +117,11 @@ class HeatPipe:
         
         # Number of struts per unit cell (4 diagonal + 12 edge struts / 4 shared)
         n_struts_diagonal = 4
-        n_struts_edge = 12/4
+        n_struts_edge = 0
         
-        # Volume of struts
-        V_strut_diagonal = math.pi * (strut_diameter/2)**2 * l_diagonal
+        # Volume of struts, corrected using Chenling's formula
+        # V_strut_diagonal = math.pi * (strut_diameter/2)**2 * l_diagonal
+        V_strut_diagonal = math.sqrt(3) * strut_diameter**2 * (math.pi * unit_cell_size - 2 * math.sqrt(2) * strut_diameter)
         V_strut_edge = math.pi * (strut_diameter/2)**2 * unit_cell_size
         
         # Total volume of solid material in unit cell
@@ -133,6 +134,7 @@ class HeatPipe:
         # Specific surface area for BCC lattice
         surface_area = (n_struts_diagonal * math.pi * strut_diameter * l_diagonal + 
                        n_struts_edge * math.pi * strut_diameter * unit_cell_size)
+        # surface_area = n_struts_diagonal * math.pi * strut_diameter * l_diagonal
         specific_surface = surface_area / V_unit_cell
         
         # Kozeny constant for BCC lattice (typical range 4.5-5.5, is this correct? I also saw this can be 2-3)
@@ -143,7 +145,8 @@ class HeatPipe:
         
         # Calculate effective thermal conductivity using Maxwell's model
         # Assuming copper as base material and water as fluid
-        k_fluid = self.fluid_properties["water"]["thermal_conductivity"]
+        fluid_properties = self.get_water_properties(operating_temp, quality=0)
+        k_fluid = fluid_properties["thermal_conductivity"]
         k_solid = material_conductivity
         volume_fraction = 1 - porosity
         
-- 
GitLab